Add testing and document support for Python 3.7 & PyPy3 #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the optional package datrie doesn't build with Python 3.7: |
|
Perhaps support for datrie should be dropped or limited to Python <=3.6. The upstream package looks unmaintained and is not releasing new versions. |
hugovk
reviewed
Oct 17, 2019
hugovk
reviewed
Oct 17, 2019
hugovk
reviewed
Oct 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage ? 90.52%
=========================================
Files ? 50
Lines ? 6973
Branches ? 1328
=========================================
Hits ? 6312
Misses ? 502
Partials ? 159Continue to review full report at Codecov.
|
|
Thanks for the review, I've made the suggested changes. |
hugovk
previously approved these changes
Oct 18, 2019
|
The Python 3.8 CI failures are due to flake8 and fixed in #428. |
hugovk
previously approved these changes
Nov 8, 2019
This comment has been minimized.
This comment has been minimized.
Python 3.7 was released on June 27, 2018. Python 3.8 was released on October 14th, 2019.
gsnedders
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 was released on June 27, 2018.
https://docs.python.org/3/whatsnew/3.7.html
Use 'dist: xenial' in Travis to allow using Python version 3.7. Travis
officially added support for Xenial on 2018-11-08.
https://blog.travis-ci.com/2018-11-08-xenial-release